Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




HI Andrew,

On Fri, May 13, 2016 at 11:13 PM, Andrew Lunn <andrew@xxxxxxx> wrote:
> Hi Harini
>
> Is this backward compatible? Will devices using the old binding still
> work?

It isn't right now.
I will have to assign the bus read/write functions conditionally in order to
do that - I'll see if I can make it clean.

>
>   /* Disable RX and TX (XXX: Should we halt the transmission
>    * more gracefully?)
>     */
> -   macb_writel(bp, NCR, 0);
> +   ctrl = macb_readl(bp, NCR);
> +   ctrl &= ~(MACB_BIT(RE) | MACB_BIT(TE));
> +   macb_writel(bp, NCR, ctrl);
>
>         /* Clear the stats registers (XXX: Update stats first?) */
> -       macb_writel(bp, NCR, MACB_BIT(CLRSTAT));
> +       ctrl |= MACB_BIT(CLRSTAT);
> +       macb_writel(bp, NCR, ctrl);
>
>         /* Clear all status flags */
>         macb_writel(bp, TSR, -1);
>
> It is not clear to me what this part has to do with MDIO.
>

Sorry, I'll move this to a separate patch in my next version.
It is intended to write those registers without disturbing reserved bits.

Regards,
Harini
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux