Hello.
On 05/13/2016 07:06 AM, Andrew Lunn wrote:
+ gpiod = fwnode_get_named_gpiod(&child->fwnode, "reset-gpios");
+ /* Deassert the reset signal */
+ if (!IS_ERR(gpiod))
+ gpiod_direction_output(gpiod, 0);
This is wrong I think. You must only ignore -ENODEV, all other error
At least -ENOSYS should also be ignored (it's returned when
gpiolib is not configured), right? When does -ENODEV gets returned
(it's not easy to follow)?
codes should be passed to the caller.
The caller doesn't care anyway...
It should do.
Tell that to Florian. So far, everybody has been happy with
of_mdiobus_register(). Until I had to touch this code. :-)
What if fwnode_get_named_gpiod() returns -EPROBE_DEFER
because the GPIO driver has not been loaded yet?
Bad luck. :-)
Seriously, I'll see what I can do but it's not a trivial case.
Andrew
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
