Hi Simon, On Tuesday 19 November 2013 10:55:39 Simon Horman wrote: > On Sun, Nov 10, 2013 at 04:33:12AM +0100, Laurent Pinchart wrote: > > Hello, > > > > This is the second version of the patch set adds device tree bindings for > > the sh sci serial port devices and adds OF parsing to the sh-sci driver. > > > > The bindings are based on Bastian Hecht's proposal (see > > http://www.spinics.net/lists/arm-kernel/msg228129.html). The approach > > taken here is more minimalistic: instead of describing all hardware > > characteristics that vary between the SCI device revisions in DT (such as > > registers layout), that information is stored in the driver and selected > > based on the compatible property value. Only SCI revisions used on ARM > > devices are supported through DT, as DT support for SuperH is nowhere > > down the line. > > > > Patches 01/29 to 06/29 clean up the sh-sci driver. > > It seems to me that these could be queued up by Greg. > Let me know if you would like me to pass them on to him. > I'm quite happy for you to do that yourself. Or to wait. > Its entirely up to you. > > In any case for those patches: > > Acked-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> Thank you. I'll resend the series with the DT bindings updated for r8a7791 and will ask Greg to pick the patches up and provide a stable branch with patches 01/29 to 07/29. > > Patches 07/29 to 27/29 replace memory and interrupt resources passed > > through platform data with platform resources. Beside replacing a custom > > mechanism with a standard one, it will also make the DT parsing code > > simpler as resource allocation will be shared between DT and non-DT code > > paths. Finally, patches 28/29 to 29/29 add OF parsing to the sh-sci driver > > and create DT bindings documentation. > > 29 is awaiting devicetree review and 28 makes little sense before that > happens. Right? Correct. > > The patches have been test on a Lager board (r8a7790-based). Support for > > other SoCs will be added as needed. Note that all current Renesas ARM > > SoCs seem to be compatible with the generic (H)SCI(F)(AB) devices, but > > the plan is for their DT bindings to list the SoC-specific version in > > case incompatibilities are found later. > > > > Patch 08/29 ("serial: sh-sci: Support resources passed through platform > > resources") is the only dependency of the arch/arm and arch/sh patches > > present in this series. As it's too late to get it in v3.13, Simon will > > need a stable branch of the linux serial tree with that patch included. > > That is patch 7 not 8, right? Yes, sorry. > Do all of the shmobile patches depends on that patch? Yes they do. > I would be happy to take some earlier if practical. > > > Changes compared to v1: > > > > - Patches 04/29 to 27/29 have been added > > - Multi-interrupt support has been removed from the DT bindings as they > > don't support any SoC requiring multi-interrupt yet > > > > Cc: devicetree@xxxxxxxxxxxxxxx > > > > Bastian Hecht (1): > > serial: sh-sci: Add OF support > > > > Laurent Pinchart (28): > > serial: sh-sci: Sort headers alphabetically > > serial: sh-sci: Remove baud rate calculation algorithm 5 > > serial: sh-sci: Simplify baud rate calculation algorithms > > serial: sh-sci: Remove duplicate interrupt check in verify port op > > serial: sh-sci: Set the UPF_FIXED_PORT flag > > serial: sh-sci: Don't check IRQ in verify port operation > > serial: sh-sci: Support resources passed through platform resources > > ARM: shmobile: sh7372: Use macros to declare SCIF devices > > ARM: shmobile: sh73a0: Use macros to declare SCIF devices > > ARM: shmobile: r8a7740: Use macros to declare SCIF devices > > ARM: shmobile: r8a7779: Use macros to declare SCIF devices > > ARM: shmobile: r7s72100: Don't define SCIF platform data in an array > > ARM: shmobile: r8a73a4: Don't define SCIF platform data in an array > > ARM: shmobile: r8a7778: Don't define SCIF platform data in an array > > ARM: shmobile: r8a7790: Don't define SCIF platform data in an array > > ARM: shmobile: r8a7791: Don't define SCIF platform data in an array > > ARM: shmobile: sh7372: Declare SCIF register base and IRQ as resources > > ARM: shmobile: sh73a0: Declare SCIF register base and IRQ as resources > > ARM: shmobile: r7s72100: Declare SCIF register base and IRQ as > > resources > > ARM: shmobile: r8a73a4: Declare SCIF register base and IRQ as > > resources > > ARM: shmobile: r8a7740: Declare SCIF register base and IRQ as > > resources > > ARM: shmobile: r8a7778: Declare SCIF register base and IRQ as > > resources > > ARM: shmobile: r8a7779: Declare SCIF register base and IRQ as > > resources > > ARM: shmobile: r8a7790: Declare SCIF register base and IRQ as > > resources > > ARM: shmobile: r8a7791: Declare SCIF register base and IRQ as > > resources > > > > sh: Declare SCIF register base and IRQ as resources > > serial: sh-sci: Remove platform data mapbase and irqs fields > > serial: sh-sci: Add device tree bindings documentation > > > > .../bindings/serial/renesas,sci-serial.txt | 42 ++++ > > arch/arm/mach-shmobile/setup-r7s72100.c | 63 +++--- > > arch/arm/mach-shmobile/setup-r8a73a4.c | 65 +++--- > > arch/arm/mach-shmobile/setup-r8a7740.c | 196 +++------------- > > arch/arm/mach-shmobile/setup-r8a7778.c | 45 ++-- > > arch/arm/mach-shmobile/setup-r8a7779.c | 129 +++-------- > > arch/arm/mach-shmobile/setup-r8a7790.c | 117 +++++----- > > arch/arm/mach-shmobile/setup-r8a7791.c | 130 +++++------ > > arch/arm/mach-shmobile/setup-sh7372.c | 161 +++----------- > > arch/arm/mach-shmobile/setup-sh73a0.c | 192 +++------------- > > arch/sh/kernel/cpu/sh2/setup-sh7619.c | 27 ++- > > arch/sh/kernel/cpu/sh2a/setup-mxg.c | 9 +- > > arch/sh/kernel/cpu/sh2a/setup-sh7201.c | 72 +++++-- > > arch/sh/kernel/cpu/sh2a/setup-sh7203.c | 36 +++- > > arch/sh/kernel/cpu/sh2a/setup-sh7206.c | 36 +++- > > arch/sh/kernel/cpu/sh2a/setup-sh7264.c | 96 +++++++-- > > arch/sh/kernel/cpu/sh2a/setup-sh7269.c | 96 +++++++-- > > arch/sh/kernel/cpu/sh3/setup-sh7705.c | 18 +- > > arch/sh/kernel/cpu/sh3/setup-sh770x.c | 27 ++- > > arch/sh/kernel/cpu/sh3/setup-sh7710.c | 18 +- > > arch/sh/kernel/cpu/sh3/setup-sh7720.c | 18 +- > > arch/sh/kernel/cpu/sh4/setup-sh4-202.c | 15 +- > > arch/sh/kernel/cpu/sh4/setup-sh7750.c | 18 +- > > arch/sh/kernel/cpu/sh4/setup-sh7760.c | 58 +++-- > > arch/sh/kernel/cpu/sh4a/setup-sh7343.c | 36 +++- > > arch/sh/kernel/cpu/sh4a/setup-sh7366.c | 9 +- > > arch/sh/kernel/cpu/sh4a/setup-sh7722.c | 27 ++- > > arch/sh/kernel/cpu/sh4a/setup-sh7723.c | 54 +++-- > > arch/sh/kernel/cpu/sh4a/setup-sh7724.c | 54 +++-- > > arch/sh/kernel/cpu/sh4a/setup-sh7734.c | 66 ++++-- > > arch/sh/kernel/cpu/sh4a/setup-sh7757.c | 27 ++- > > arch/sh/kernel/cpu/sh4a/setup-sh7763.c | 27 ++- > > arch/sh/kernel/cpu/sh4a/setup-sh7770.c | 90 ++++++-- > > arch/sh/kernel/cpu/sh4a/setup-sh7780.c | 18 +- > > arch/sh/kernel/cpu/sh4a/setup-sh7785.c | 54 +++-- > > arch/sh/kernel/cpu/sh4a/setup-sh7786.c | 82 +++++-- > > arch/sh/kernel/cpu/sh4a/setup-shx3.c | 45 ++-- > > arch/sh/kernel/cpu/sh5/setup-sh5.c | 11 +- > > drivers/tty/serial/sh-sci.c | 238 +++++++++++++--- > > include/linux/serial_sci.h | 35 +-- > > 40 files changed, 1443 insertions(+), 1114 deletions(-) > > create mode 100644 > > Documentation/devicetree/bindings/serial/renesas,sci-serial.txt -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html