Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Krzysztof,

Sorry for not acting on the feedback sooner - I lost the email in my
Inbox!

I've tested the patch on my Origen board and it works fine.  One small
comment in-line.

Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> writes:

> From: Matthew Leach <matthew@xxxxxxxxxxxxx>
>
> Enable the Origen's usb phy and ohci devices in the device tree.  Also
> add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so
> the AX88760 hub is powered.
>
> Signed-off-by: Matthew Leach <matthew@xxxxxxxxxxxxx>
> [k.kozlowski: Extend nodes by label notation instead of path]
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
> index 8bca699b7f20..4c59bdb0e6f3 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -77,12 +77,29 @@
>  			clock-frequency = <24000000>;
>  		};
>  	};
> +

I think we could loose this line break?

Thanks,
-- 
Matt
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux