On Wed, May 11, 2016 at 05:31:30PM +0800, Henry Chen wrote:
> +The possible values for "regulator-supported-modes" are:
> + 0: PWM mode, mapping to regulator fast mode, allow the
> + converter to remain in the PWM mode regardless of the load current, so
> + that the noise spectrum of the converter can be minimized for certain
> + highly-noise-sensitive handset applications.
> + 1: Auto mode, mapping to regulator normal mode, mode switch by current
> + loading. At light load currents, the converter automatically enters
> + PFM mode to save power and improve light load efficiency. At heavy
> + load currents, the converter automatically enters PWM mode to minimiz
> + the noise spectrum of the converter.
The details of how this maps onto Linux shouldn't be in the bindings.
> + regulator-allow-change-mode;
> + regulator-supported-modes = <0 1>;
These are problematic too as covered in my other mail.
> -static struct regulator_ops mt6397_volt_range_ops = {
> +static const struct regulator_ops mt6397_volt_range_ops = {
The constification is fine but an unrelated change. Otherwise this
looks fine from a code point of view, let's get that merged separately.
Attachment:
signature.asc
Description: PGP signature
