Re: [PATCHv3 1/4] ARM: dts: r8a7790: Reference both DMA controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2016-05-11 15:45:17 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
> 
> On Wed, May 11, 2016 at 3:13 PM, Niklas Söderlund
> <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> > R-Car Gen2 have two DMA controllers, which are equivalent. Add
> > references to both dmac0 and dmac1 so the driver can choose which one to
> > use.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/r8a7790.dtsi | 131 ++++++++++++++++++++++++-----------------
> >  1 file changed, 78 insertions(+), 53 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> > index 83cf23c..14fcd19 100644
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> 
> > @@ -755,9 +773,9 @@
> >                 clocks = <&mstp3_clks R8A7790_CLK_SCIF2>, <&zs_clk>,
> >                          <&scif_clk>;
> >                 clock-names = "fck", "brg_int", "scif_clk";
> > -               dmas = <&dmac0 0x2b>, <&dmac0 0x2c>;
> > -               dma-names = "tx", "rx";
> > -               power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
> 
> Please keep the above line.

My mistake, the above line was not meant to be removed.. thanks for 
pointing it out.

> 
> > +               dmas = <&dmac0 0x2b>, <&dmac0 0x2c>,
> > +                      <&dmac1 0x2b>, <&dmac1 0x2c>;
> > +               dma-names = "tx", "rx", "tx", "rx";
> >                 status = "disabled";
> >         };
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Regards,
Niklas Söderlund
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux