Hi,
On Fri, May 06, 2016 at 01:10:20PM +0200, Christian Lamparter wrote:
> +static int bgpio_basic_mmio_parse_dt(struct platform_device *pdev,
> + struct bgpio_pdata *pdata,
> + unsigned long *flags)
> +{
> + struct device *dev = &pdev->dev;
> + int err;
> +
> + pdata->base = -1;
> + /* If ngpio property is not specified, of_property_read_u32
> + * will return -EINVAL. In this case the number of GPIOs is
> + * automatically determined by the register width. Any
> + * other error of of_property_read_u32 is due bad data and
> + * needs to be dealt with.
> + */
> + err = of_property_read_u32(dev->of_node, "ngpio", &pdata->ngpio);
> + if (err && err != -EINVAL)
> + return err;
> +
> + if (of_device_is_big_endian(dev->of_node))
> + *flags |= BGPIOF_BIG_ENDIAN_BYTE_ORDER;
> +
> + if (of_property_read_bool(dev->of_node, "unreadable-reg-set"))
> + *flags |= BGPIOF_UNREADABLE_REG_SET;
> +
> + if (of_property_read_bool(dev->of_node, "unreadable-reg-dir"))
> + *flags |= BGPIOF_UNREADABLE_REG_DIR;
> +
> + if (of_property_read_bool(dev->of_node, "big-endian-byte-order"))
> + *flags |= BGPIOF_BIG_ENDIAN;
> +
> + if (of_property_read_bool(dev->of_node, "read-output-reg-set"))
> + *flags |= BGPIOF_READ_OUTPUT_REG_SET;
> +
> + if (of_property_read_bool(dev->of_node, "no-output"))
> + *flags |= BGPIOF_NO_OUTPUT;
> + return 0;
> +}
Other than no-output, none of these are in the wd,mbl-gpio binding.
Please remove them for now. We can add them as/when other users of this
binding appear and begin to need them.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
