Hello Krzysztof, On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: > On Odroid U3 (Exynos4412-based) board if USB was initialized by > bootloader (in U-Boot "usb start" before tftpboot), the HUB (usb3503) > and LAN (smsc95xx) after after successful probing were not visible in the > system ("lsusb"). > > In such case the devices had to be fully reset before configuring. > Reset by GPIO (called RESET_N pin) and by RESET field in STCD register > in usb3503 HUB are not sufficient. Instead full reset has to be done by > disabling and enabling regulator. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > --- [snip] > > + lan_pwrseq: pwrseq2 { > + compatible = "mmc-pwrseq-simple"; It feels strange to have a "mmc-pwrseq-simple" compatible for a USB power sequence provider. As I mentioned in the other patch, I think there should either be a DT binding for the USB pwrseq-simple with a "usb-pwrseq-simple" compatible that binds to the same pwrseq-simple driver or maybe having a generic DT binding for any device with a new "pwrseq-simple" compatible. Patch looks good to me though, so after having a DT binding and changing the compatible string: Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html