On Thu, May 5, 2016 at 7:38 AM, Crestez Dan Leonard <leonard.crestez@xxxxxxxxx> wrote: > On 05/01/2016 08:27 PM, Jonathan Cameron wrote: >> On 29/04/16 20:02, Crestez Dan Leonard wrote: >>> --- a/Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt >>> +++ b/Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt >>> @@ -1,16 +1,27 @@ >>> InvenSense MPU-6050 Six-Axis (Gyro + Accelerometer) MEMS MotionTracking Device >>> >>> -http://www.invensense.com/mems/gyro/mpu6050.html >> If this is invalid, please add an up to date link if possible. >>> - >>> Required properties: >>> - - compatible : should be "invensense,mpu6050" >>> - - reg : the I2C address of the sensor >>> + - compatible : should be "invensense,mpuXXXX" >> List them all explicitly here rather than wild cards. >> > But the list is a bit long. I'll just write "see below for valid > compatible strings". No, please list here. 4 is not long. A note of which ones are SPI would be good too. Can you add 9250 as well as it is commonly available for maker h/w. > >>> + - reg : the I2C or SPI address of the sensor >>> - interrupt-parent : should be the phandle for the interrupt controller >>> - interrupts : interrupt mapping for GPIO IRQ >>> >>> Optional properties: >>> - mount-matrix: an optional 3x3 mounting rotation matrix >>> + - inv,i2c-aux-master: operate aux i2c in "master mode" (default is mux). >>> + >>> +Valid compatible strings: >> Vendor prefix? These will work for historical reasons, but now vendor >> prefix should definitely be there as well. >>> + - mpu6000 >>> + - mpu6050 >>> + - mpu6500 >>> + - mpu9150 >> > The driver currently only lists i2c_device_id and this will work > ignoring the vendor string. I can prefix all these valid strings with > the vendor prefix but this is not actually a requirement. That would > require a separate unrelated patch adding of_device_id tables. What the driver happens to do is irrelevant to the binding. From a binding standpoint, the vendor prefix is always required. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
