On Tue, May 3, 2016 at 11:53 PM, Christian Lamparter <chunkeey@xxxxxxxxxxxxxx> wrote: > On Tuesday, May 03, 2016 09:22:10 PM Rob Herring wrote: >> On Sun, May 01, 2016 at 02:18:37PM +0200, Christian Lamparter wrote: >> > This patch adds the device tree bindings for the Western Digital's >> > MyBook Live memory-mapped GPIO controllers. >> > >> > The gpios will be supported by gpio-mmio code of the >> > GPIO generic library. >> > >> > +++ b/Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt >> > @@ -0,0 +1,38 @@ >> > +Bindings for the Western Digital's MyBook Live memory-mapped GPIO controllers. >> >> Are these really product level GPIOs rather than some SOC's GPIOs >> (APM?)? >> > Ah, that's a good point. > > In a nutshell: The APM82181 SoC has two proper/normal GPIO controllers > which have a dt-binding and a kernel driver ready to go. > However Western Digital went with their own GPIO controller for > the MyBook Live [7]. Okay, just making sure. It's a little strange to have external (to an SOC) memory mapped GPIOs is why I asked. Acked-by: Rob Herring <robh@xxxxxxxxxx> Rob P.S. By v6, you should drop RFC. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html