On 2016年05月04日 10:25, Wei Ni wrote: > > > On 2016年05月03日 23:21, Thierry Reding wrote: >> * PGP Signed by an unknown key >> >> On Tue, May 03, 2016 at 05:09:37PM +0800, Wei Ni wrote: >>> This patch changes the compatible of Tegra132 fuse node >>> to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse". >>> Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for >>> Tegra132, the fuse driver can't find the corresponding node. >> >> Okay, that's not really a good reason to modify the DTS. What we should >> do instead is make sure that the OF table contains the entry on Tegra132 >> builds. Unless the IP block really is different and Tegra124 and >> Tegra132 aren't compatible in this regard after all. >> >> In the latter case the commit message should reflect the real reason. Hi Thierry, I read the Documentation/devicetree/bindings/fuse/nvidia,tegra20-fuse.txt, it has description: - compatible : For Tegra20, must contain "nvidia,tegra20-efuse". For Tegra30, must contain "nvidia,tegra30-efuse". For Tegra114, must contain "nvidia,tegra114-efuse". For Tegra124, must contain "nvidia,tegra124-efuse". Otherwise, must contain "nvidia,<chip>-efuse", plus one of the above, where <chip> is tegra132. It mean for Tegra132, it should use "nvidia,tegra132-efuse". So if we don't change the DTS file, I need to fix the OF table in the driver and update the of-bindings, is it right? Wei. > > Hi Thierry, > > The fuse driver fuse-tegra.c has following OF table: > #ifdef CONFIG_ARCH_TEGRA_132_SOC > { .compatible = "nvidia,tegra132-efuse", .data = &tegra124_fuse_soc }, > #endif > #ifdef CONFIG_ARCH_TEGRA_124_SOC > { .compatible = "nvidia,tegra124-efuse", .data = &tegra124_fuse_soc }, > #endif > > It defined "nvidia,tegra124-efuse" under CONFIG_ARCH_TEGRA_124_SOC, so if we > don't change the DTS file, we should change it as: > -#ifdef CONFIG_ARCH_TEGRA_132_SOC > - { .compatible = "nvidia,tegra132-efuse", .data = &tegra124_fuse_soc }, > -#endif > -#ifdef CONFIG_ARCH_TEGRA_124_SOC > +#if defined CONFIG_ARCH_TEGRA_124_SOC || defined CONFIG_ARCH_TEGRA_132_SOC > { .compatible = "nvidia,tegra124-efuse", .data = &tegra124_fuse_soc }, > #endif > #ifdef CONFIG_ARCH_TEGRA_114_SOC > > I will send it out. > >> >> Thierry >> >> * Unknown Key >> * 0x7F3EB3A1 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html