On 5/3/2016 4:12 PM, Arnd Bergmann wrote: > On Sunday 01 May 2016 17:07:50 Sinan Kaya wrote: >> The patchset makes three different changes. >> 1. Add support for probing ACPI platform devices. >> 2. Add support for ACPI _RST method support during reset >> 3. Make reset driver a requirement by default with an optional >> kernel command line override > > Looks nice, thanks for rewriting this! > > For future submissions, it would help to have a list of changes > compared to the previous versions a the patch set in the cover > letter to help reviewers, but this time my memory was still fresh > enough. > > Arnd > Sure, will do. I asked Rafael to review the ACPI code. + ret = vfio_platform_call_reset(vdev); This is the only problem I'm seeing in the code. I tested the ACPI path only. I'm wondering if Eric could test the device tree version. + if (ret) + goto err_irq; I'll get rid of this line on the first patch and move it to second patch along with reset_required check. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
