On 03/05/16 13:48, Laxman Dewangan wrote: > > On Tuesday 03 May 2016 06:25 PM, Jon Hunter wrote: >> >>> >>> Currently SOR driver is using the tegra_io_rail_power_off/on() APIs. >>> Once the proper interface available then I will move sor driver to use >>> new method and then we can full get rid of older APIs and macros. >>> >>> Till that, we need to have this. >> I prefer it is done before this series. In other words, if we need a >> proper enum for the rail/pad IDs then add one and convert any existing >> drivers over to use any new APIs first. > > But the converting to new API can be done after this patch only. Yes but before you add the pinctrl driver. May be you should separate the two. My point is that any follow-up series to this, would have to touch the pmc and the sor driver. So why not make the changes for the pmc and sor now, and once in place then add the pinctrl driver? Jon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html