On Mon, Nov 18, 2013 at 02:54:00PM +0000, Russell King - ARM Linux wrote: > On Mon, Nov 18, 2013 at 04:30:17PM +0200, Andy Shevchenko wrote: > > On Mon, 2013-11-18 at 13:16 +0100, Florian Meier wrote: > > > >> + uint32_t chans_available; > > > > > > > > Why uint32_t? > > > > > > Because it is a bit mask of fixed length that directly comes from the > > > firmware. > > > > Like one already told you in your i2s patch, please, change that to > > corresponding u* value, namely u32. > > There's no problem with uint32_t vs u32 - either will do. u32 is the > pre-stdint.h Linux definition of a 32-bit unsigned integer. There's > no reason why uint32_t isn't perfectly acceptable. It's a matter of > author taste which gets used. (Except where modifications are to an > existing chunk of code using one or the other - where consistency then > matters more.) Sorry for being a source of confusion here. I won't push this point in future. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html