On Monday 02 May 2016 12:35:01 Sanchayan Maity wrote:
> + ocotp@400a5000 {
> + compatible = "fsl,vf610-ocotp";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0x400a5000 0xCF0>;
> + clocks = <&clks VF610_CLK_OCOTP>;
> +
> + ocotp_cfg0: cfg0@410 {
> + reg = <0x410 0x4>;
> + };
> +
> + ocotp_cfg1: cfg1@420 {
> + reg = <0x420 0x4>;
> + };
> + };
How do the registers of the child nodes relate to the registers of the
parent? If there are in the same address space, it might be good to
add a "ranges" property to describe it.
Arnd--- Begin Message ---
- Subject: Re: [PATCH v8 40/45] drivers/of: Split unflatten_dt_node()
- From: Gavin Shan <gwshan@xxxxxxxxxxxxxxxxxx>
- Date: Mon, 02 May 2016 12:02:21 +1000
- Cc: "devicetree@xxxxxxxxxxxxxxx" <devicetree@xxxxxxxxxxxxxxx>, aik@xxxxxxxxx, Gavin Shan <gwshan@xxxxxxxxxxxxxxxxxx>, Grant Likely <grant.likely@xxxxxxxxxx>, "linux-pci@xxxxxxxxxxxxxxx" <linux-pci@xxxxxxxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, linuxppc-dev <linuxppc-dev@xxxxxxxxxxxxxxxx>, dja@xxxxxxxxxx
- Delivered-to: linuxppc-dev@xxxxxxxxxxxxxxxx
- Envelope-to: <arnd@xxxxxxxx>
- In-reply-to: <CAL_Jsq++L-D=RD6ZYK=CPnhqcZbhEbxsKk3xT-vK2R=Qe9Z_pg@mail.gmail.com>
- Reply-to: Gavin Shan <gwshan@xxxxxxxxxxxxxxxxxx>
- User-agent: Mutt/1.5.23 (2014-03-12)
On Wed, Feb 17, 2016 at 08:30:42AM -0600, Rob Herring wrote:
>On Tue, Feb 16, 2016 at 9:44 PM, Gavin Shan <gwshan@xxxxxxxxxxxxxxxxxx> wrote:
>> The function unflatten_dt_node() is called recursively to unflatten
>> device nodes and properties in the FDT blob. It looks complicated
>> and hard to be understood.
>>
>> This splits the function into 3 functions: populate_properties(),
>> populate_node() and unflatten_dt_node(). populate_properties(),
>> which is called by populate_node(), creates properties for the
>> indicated device node. The later one creates the device nodes
>> from FDT blob. populate_node() gets the offset in FDT blob for
>> next device nodes and then calls populate_node(). No logical
>> changes introduced.
>>
>> Signed-off-by: Gavin Shan <gwshan@xxxxxxxxxxxxxxxxxx>
>> ---
>> drivers/of/fdt.c | 249 ++++++++++++++++++++++++++++++++-----------------------
>> 1 file changed, 147 insertions(+), 102 deletions(-)
>
>One nit, otherwise:
>
>Acked-by: Rob Herring <robh@xxxxxxxxxx>
>
>[...]
>
>> + /* And we process the "ibm,phandle" property
>> + * used in pSeries dynamic device tree
>> + * stuff
>> + */
>> + if (!strcmp(pname, "ibm,phandle"))
>> + np->phandle = be32_to_cpup(val);
>> +
>> + pp->name = (char *)pname;
>> + pp->length = sz;
>> + pp->value = (__be32 *)val;
>
>This cast should not be needed.
>
It's needed. Otherwise, we will have warning. So I will keep it. I just
went through this one for next revision and sorry for late response.
drivers/of/fdt.c:225:14: warning: assignment discards ‘const’ qualifier from pointer target type
pp->value = val;
^
Thanks,
Gavin
>> + *pprev = pp;
>> + pprev = &pp->next;
>> + }
>
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@xxxxxxxxxxxxxxxx
https://lists.ozlabs.org/listinfo/linuxppc-dev
--- End Message ---
