On Fri, Apr 29, 2016 at 01:55:14PM +0200, Krzysztof Kozlowski wrote: > On 04/29/2016 01:30 PM, Mark Brown wrote: > > Supplies are only optional if they may be physically absent. In this > > case it's possible that on device regulators may be used instead, a > > pattern more like that used for arizona-ldo1 where we represent those > > regulators might be better as it's more clearly describing the > > situation. I'm just wondering if the supply lookup stuff there should > > be factored out as this is not an uncommon pattern.. > > It should at least be clearly stated what's going on, ignoring failure > > to get supplies is generally a bug and people will tend to blindly cut > > and paste things (witness all the breakage in graphics drivers with > > this). > The VDD33 is really optional. The device can work in different > configuration, e.g. only on VBAT. How the reset logic would work then? I > don't know... I would suspect that it could be exactly the same (just > replace VDD33 with VBAT) but I am not sure. What the Arizona example I mentioned does is look for the property specifying an external supply in DT and if there isn't one assumes that it must be using the internal regulator. That's a bit icky but it does the right thing and is much simpler from a user point of view.
Attachment:
signature.asc
Description: PGP signature
