One more thing: On Thu, Apr 28, 2016 at 09:03:53AM -0700, Brian Norris wrote: > Hi Heiko, Jianqun, > > On Wed, Apr 27, 2016 at 03:54:51PM +0800, Jianqun Xu wrote: > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > new file mode 100644 > > index 0000000..5a8a915 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > @@ -0,0 +1,1022 @@ > [...] > > + sdhci: sdhci@fe330000 { > > + compatible = "rockchip,rk3399-sdhci-5.1", "arasan,sdhci-5.1"; > > Not to rain on the parade too much, as this is already applied, but is > the "rockchip,rk3399-sdhci-5.1" string documented anywhere? I don't see > it. According to the latest binding for "arasan,sdhci-5.1", the "phy" and "phy-names" properties are required. Fortunately, this device stays "disabled" for now in your EVB DTS. But just FYI. > > + reg = <0x0 0xfe330000 0x0 0x10000>; > > + interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cru SCLK_EMMC>, <&cru ACLK_EMMC>; > > + clock-names = "clk_xin", "clk_ahb"; > > + status = "disabled"; > > + }; Brian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html