On Mon, Apr 25, 2016 at 4:11 PM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > Adding devicetree overlords... > > On Wed, Apr 20, 2016 at 08:54:43AM +0200, Dirk Behme wrote: >> From: Knut Wohlrab <Knut.Wohlrab@xxxxxxxxxxxx> >> >> Add device tree support for idle and finger scanning frequency. >> >> Signed-off-by: Knut Wohlrab <Knut.Wohlrab@xxxxxxxxxxxx> >> Signed-off-by: Oleksij Rempel <linux@xxxxxxxxxxxxxxxx> >> Signed-off-by: Dirk Behme <dirk.behme@xxxxxxxxxxxx> >> --- >> .../devicetree/bindings/input/touchscreen/zforce_ts.txt | 4 ++++ >> drivers/input/touchscreen/zforce_ts.c | 15 ++++++++++++++- >> include/linux/platform_data/zforce_ts.h | 2 ++ >> 3 files changed, 20 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/input/touchscreen/zforce_ts.txt b/Documentation/devicetree/bindings/input/touchscreen/zforce_ts.txt >> index e3c27c4..09ead84 100644 >> --- a/Documentation/devicetree/bindings/input/touchscreen/zforce_ts.txt >> +++ b/Documentation/devicetree/bindings/input/touchscreen/zforce_ts.txt >> @@ -11,6 +11,8 @@ Required properties: >> Optional properties: >> - irq-gpios : interrupt gpio the chip is connected to BTW, this should really be an "interrupts" property >> - vdd-supply: Regulator controlling the controller supply >> +- scan-freq-idle: idle scanning frequency in Hz (0 - 65535 Hz; default 10 Hz) >> +- scan-freq-finger: touch scanning frequeny in Hz (0 - 65535 Hz; default 50 Hz) I use my toes for touchscreens. Can you really scan at 65kHz? a typo here as well. > Should we cal it scan-freq-active instead? Don't we have a standard property for this? These should really have -hz appended. So scan-idle-hz and scan-active-hz, but at least the active case should be common IMO. Idle scan seems a bit unusual unless you don't have an interrupt. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html