Re: [PATCH V8 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Tomasz,

On Sat, Nov 16, 2013 at 5:13 AM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote:
> On Tuesday 12 of November 2013 12:04:46 Leela Krishna Amudala wrote:
>> This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to
>> handle PMU register accesses in a centralized way using syscon driver
>>
>> Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx>
>> Reviewed-by: Tomasz Figa <t.figa@xxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/arm/samsung/pmu.txt |   13 +++++++++++++
>>  arch/arm/boot/dts/exynos5250.dtsi                     |    5 +++++
>>  arch/arm/boot/dts/exynos5420.dtsi                     |    5 +++++
>>  3 files changed, 23 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt
>>
>> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>> new file mode 100644
>> index 0000000..90f975d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>> @@ -0,0 +1,13 @@
>> +SAMSUNG Exynos SoC series PMU Registers
>> +
>> +Properties:
>> + - name : should be 'syscon';
>> + - compatible : should contain "samsung,<chip name>-pmu", "syscon";
>
> AFAIR there was a discussion about using <chip name> wildcards some
> time ago and if I remember correctly, the conclusion was that the list
> of all supported compatible values should be provided anyway, so there
> is no point in using such wildcards.
>
> This is how I would write this:
>
>  - compatible : should contain two values. First value must be one from
>    following list:
>      - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
>      - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
>    Second value must be always "syscon".
>

Okay, will change it

Best Wishes,
Leela Krishna

> Best regards,
> Tomasz
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux