Re: [PATCH v4 1/3] mmc: dt: usdhi6rol0: add optional pinctrl binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, Apr 26, 2016 at 7:23 AM, Lars Persson <lars.persson@xxxxxxxx> wrote:
>
>
> On 04/22/2016 10:27 PM, Rob Herring wrote:
>>
>> On Thu, Apr 21, 2016 at 03:55:42PM +0200, Lars Persson wrote:
>>>
>>> Add a pinctrl binding to specify different pin settings for high speed
>>> modes and UHS modes.
>>>
>>> Signed-off-by: Lars Persson <larper@xxxxxxxx>
>>> ---
>>>   Documentation/devicetree/bindings/mmc/usdhi6rol0.txt | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>>> b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>>> index 8babdaa..6d1b797 100644
>>> --- a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>>> +++ b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>>> @@ -12,6 +12,12 @@ Optional properties:
>>>
>>>   - vmmc-supply:        a phandle of a regulator, supplying Vcc to the
>>> card
>>>   - vqmmc-supply:       a phandle of a regulator, supplying VccQ to the
>>> card
>>> +- pinctrl-names: Can contain a "default" entry and a "state_uhs"
>>
>>
>> Don't use underscores. Just "uhs" should be sufficient, right?
>
>
> I do not object to this, but for consistency it seems better with state_uhs
> that existing bindings use.

Okay. Consistency is better.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux