Re: [PATCH 1/5] mfd: tps65217: Add support for IRQs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




ping

On 11.04.2016 11:44, Lee Jones wrote:
FAO Mark,

On 05.04.2016 12:07, Grygorii Strashko wrote:
On 04/04/2016 08:11 PM, Marcin Niestroj wrote:
Add support for handling IRQs: power button, AC and USB power state
changes. Mask and interrupt bits are shared within one register, which
prevents us to use regmap_irq implementation. New irq_domain is
created in
order to add interrupt handling for each tps65217's subsystem. IRQ
resources have been added for charger subsystem to be able to notify
about
AC and USB state changes.

Signed-off-by: Marcin Niestroj <m.niestroj@xxxxxxxxxxxxxxxx>
---

Just curious Why not use a regmap_irq?

tps65217 has IRQ mask and status bits in a single register.
regmap_irq works in case of two different registers (one mask, one
status), but with the same layout of mask and status bits in both.

Mark, is this the right approach?  Or is there another way regmap_irq
can be manipulated to support this configuration?


--
Marcin Niestrój
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux