Hi Rob, Thanks for your suggestion. I will put DT bindings in separate patches, and modify related dts file in next version. Thanks, Yisen 在 2016/4/23 4:44, Rob Herring 写道: > On Fri, Apr 22, 2016 at 03:20:13PM +0800, Yisen Zhuang wrote: >> Add the subctrl reset offset for dsaf, this property is used to reset >> xge/ge ports for different dsaf. If this attribute is not present, >> default value 0 will be used. >> >> Signed-off-by: Daode Huang <huangdaode@xxxxxxxxxxxxx> >> Signed-off-by: Yisen Zhuang <yisen.zhuang@xxxxxxxxxx> >> --- >> .../devicetree/bindings/net/hisilicon-hns-dsaf.txt | 2 ++ > > Please put DT bindings in separate patches and don't modify the same > binding in a series of patches. You are describing h/w and the h/w is > not changing. > >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 8 +++++ >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h | 1 + >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 40 +++++++++++++++------- >> 4 files changed, 39 insertions(+), 12 deletions(-) > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
