On Thu, Apr 21, 2016 at 7:24 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote:
> On Thu, Apr 21, 2016 at 05:58:45AM -0700, Ashok Kumar wrote:
>> +static int armv8_vulcan_pmu_init(struct arm_pmu *cpu_pmu)
>> +{
>> + armv8_pmu_init(cpu_pmu);
>> + cpu_pmu->name = "armv8_brcm_vulcan";
>
> Are we happy with "brcm" being the exposed userspace name? It might be
> better to have this as "armv8_broadcom_vulcan".
Broadcom uses "brcm" as the vendor prefix in device trees, and the
cpu's compatible string is "brcm,vulcan", so this should be ok.
It looks like the A53 and A57 entries have established a convention of
calling the PMU "armv8_<cpuname>". Otherwise, something very close
to the PMU's OF compatible string would have been better here.
> I'll leave that to you and Will. Either way:
>
> Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
If needed:
Acked-by: Jayachandran C <jchandra@xxxxxxxxxxxx>
for the Broadcom Vulcan related changes in the whole series.
JC.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
