On Thursday 14 November 2013, Marek Belisko wrote: > DT bindings contains more parameters to set so add them to platform data also > to have possibility to use on arch where DT isn't available yet. > > Signed-off-by: Marek Belisko <marek@xxxxxxxxxxxxx> Can you give an example of a platform that uses this chip and cannot yet use DT in the mainline kernel? If it's only for out-of-tree platforms, I'd prefer to leave this patch out of tree as well and put the burden on whoever maintains a non-DT platform in a private kernel. > diff --git a/include/linux/i2c/bmp085.h b/include/linux/i2c/bmp085.h > index b66cb98..addb972 100644 > --- a/include/linux/i2c/bmp085.h > +++ b/include/linux/i2c/bmp085.h Shouldn't this be in include/linux/platform_data? Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html