On Thursday 14 November 2013, Loc Ho wrote: > +Required properties: > +- compatible : Shall be "apm,xgene-ahci" > +- reg : First memory resource shall be the AHCI memory > + resource. > + Second memory resource shall be the host controller > + memory resource. > +- id : Controller ID (0 = first, 1 = second, 2 = third) As in the PHY patch, it's probably best to drop the "id" property here and describe the actual differences between the instances directly, either by having distinct "compatible" properties for each model, or by adding binary flags to tell about a capability that only some instances have. Also, I think you should have a separate file for the sata binding, especially since the PHY binding is not actually specific to SATA at all. Aside from these, the binding looks good to me now. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
