On Sun, 10 Apr 2016 02:50:06 -0700
Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> Hi,
>
> On Wed, Mar 30, 2016 at 06:50:43PM +0200, Jean-Francois Moine wrote:
> > Add the PLL type which is used by the sun6i/8i families for video display.
> >
> > Signed-off-by: Jean-Francois Moine <moinejf@xxxxxxx>
> > ---
> > Documentation/devicetree/bindings/clock/sunxi.txt | 1 +
> > drivers/clk/sunxi/clk-sunxi.c | 65 +++++++++++++++++++++++
> > 2 files changed, 66 insertions(+)
[snip]
> > diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> > index 0581e1b..270f2a9 100644
> > --- a/drivers/clk/sunxi/clk-sunxi.c
> > +++ b/drivers/clk/sunxi/clk-sunxi.c
> > @@ -23,6 +23,7 @@
> > #include <linux/slab.h>
> > #include <linux/spinlock.h>
> > #include <linux/log2.h>
> > +#include <linux/rational.h>
> >
> > #include "clk-factors.h"
> >
> > @@ -1129,6 +1130,70 @@ CLK_OF_DECLARE(sun6i_pll6, "allwinner,sun6i-a31-pll6-clk",
> > sun6i_pll6_clk_setup);
> >
> > /*
> > + * sun6i pll3
> > + *
> > + * if (p == 0) rate = k ? 270MHz : 297MHz
> > + * else rate = parent_rate / (m + 1) * (n + 1);
> > + */
> > +static void sun6i_pll3_factors(struct factors_request *req)
> > +{
> > + unsigned long n, m;
> > +
> > + if (req->rate == 270000000) {
> > + req->m = 0;
> > + req->p = 0;
> > + req->k = 0;
> > + } else if (req->rate == 297000000) {
> > + req->m = 0;
> > + req->p = 0;
> > + req->k = 1;
> > + } else {
> > + rational_best_approximation(req->rate,
> > + req->parent_rate,
> > + 1 << 7, 1 << 4, &n, &m);
> > + req->rate = req->parent_rate / m * n;
> > + req->p = 1;
> > + req->m = m - 1;
> > + req->n = n - 1;
> > + }
> > +}
> > +
> > +static void sun6i_pll3_recalc(struct factors_request *req)
> > +{
> > + if (req->p)
> > + req->rate = req->parent_rate / (req->m + 1) * (req->n + 1);
> > + else if (req->k)
> > + req->rate = 270000000;
> > + else
> > + req->rate = 297000000;
> > +}
> > +
> > +static const struct clk_factors_config sun6i_pll3_config = {
> > + .mshift = 0,
> > + .mwidth = 4,
> > + .nshift = 8,
> > + .nwidth = 7,
> > + .pshift = 24, /* mode selection fractional / integer */
> > + .pwidth = 1,
> > + .kshift = 25, /* fraction 270 / 297 MHz */
> > + .kwidth = 1,
> > +};
>
> That's not what p and k are.
>
> Please add extra parameters to deal with fractional rates in the
> clk_factors_config (like an extra bit + an array with the two rate
> exposed.
>
> That way, you can also deal with it in the core, instead of doing a
> hack.
It is really a good way to add generic code for only one clock?
Otherwise, there is no 'P' nor 'K' in the pll3 documentation, what is
the trouble of using the variables 'p' and 'k' for other functions? And
noone said that the variables should have the same name as those of the
documentation.
Anyway, I am stupid and obedient: this code was proposed by Chen-Yu Tsai
on Sat, 6 Feb 2016 17:56:00 +0800:
> clk-factors now supports a custom .recalc callback. Along with get_factors,
> you can support pretty much any clock that has four variables, not including
> the mux and clock gate.
>
> So for this you'd have the div as factor m, and the integer mode bit as p,
> and the fraction bit as n, and recalc would be somewhat like this:
>
> if (p) {
> rate = parent_rate / (m + 1);
> } else if (n) {
> rate = 297000000;
> } else {
> rate = 270000000;
> }
>
> get_factors should be easy enough to figure out.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
