On Tue, Apr 05, 2016 at 09:46:19AM +0200, michael.hennerich@xxxxxxxxxx wrote: > From: Paul Cercueil <paul.cercueil@xxxxxxxxxx> > > This patch adds support for the AD5592R (spi) and AD5593R (i2c) > ADC/DAC/GPIO devices. > > Signed-off-by: Paul Cercueil <paul.cercueil@xxxxxxxxxx> > Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > --- > > Changes since v1: > * Fix mutex usage > * Remove unnecessary NULL pointer guards > * Add comment explaining the invalid data read > * AD5593R Remove surplus adc readback > > Changes since v2: > * Use child nodes to describe channels > * Fix probe return and driver remove path > * Move locking closer to where its used > * Remove WARN_ON but return error > * Remove OPEN DRAIN configuration option > > Changes since v3: > * Documentation: Add missing vendor prefixes in the examples > * Minor function reordering in remove() to match the reverse of probe() > > Changes since v4: > * Documentation: Add missing gpio bindings > * Kconfig: Select GPIOLIB and remove ifdefs in code > * Remove surplus error check in ad5592r_gpio_request() > * Add comment about reset magic > > Changes since v5: > * Remove surplus error check > * Remove additional ifdef CONFIG_GPIOLIB guards in the header > * Bindings: Add additional comments about CH_MODE_DAC_AND_ADC mode > --- > .../devicetree/bindings/iio/dac/ad5592r.txt | 155 +++++ I've acked this twice before, and the last change seems minor. Please add acks unless it is more than minor changes and you need it reviewed again. Acked-by: Rob Herring <robh@xxxxxxxxxx> > drivers/iio/dac/Kconfig | 27 + > drivers/iio/dac/Makefile | 3 + > drivers/iio/dac/ad5592r-base.c | 691 +++++++++++++++++++++ > drivers/iio/dac/ad5592r-base.h | 76 +++ > drivers/iio/dac/ad5592r.c | 164 +++++ > drivers/iio/dac/ad5593r.c | 131 ++++ > include/dt-bindings/iio/adi,ad5592r.h | 16 + > 8 files changed, 1263 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5592r.txt > create mode 100644 drivers/iio/dac/ad5592r-base.c > create mode 100644 drivers/iio/dac/ad5592r-base.h > create mode 100644 drivers/iio/dac/ad5592r.c > create mode 100644 drivers/iio/dac/ad5593r.c > create mode 100644 include/dt-bindings/iio/adi,ad5592r.h > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
