On Wed, 2016-04-06 at 16:00 -0700, Sören Brinkmann wrote:
> On Wed, 2016-04-06 at 22:13:59 +0000, Koul, Vinod wrote:
> > On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote:
> > > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote:
> > > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > > > > +++
> > > > > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.t
> > > > > > xt
> > > > > > @@ -24,8 +24,8 @@ Optional properties:
> > > > > > {3}, flush s2mm channel
> > > > > >
> > > > > > Required child node properties:
> > > > > > -- compatible: It should be either "xlnx,axi-vdma-mm2s
> > > > > > -channel"
> > > > > > or
> > > > > > - "xlnx,axi-vdma-s2mm-channel".
> > > > > > +- compatible: It should be either "xlnx,axi-dma-mm2s
> > > > > > -channel"
> > > > > > or
> > > > > > + "xlnx,axi-dma-s2mm-channel".
> > > > >
> > > > > This change is not backwards compatible and breaks every user
> > > > > of
> > > > > the current
> > > > > binding.
> > > >
> > > > This commit
> > > > http://git.kernel.org/cgit/linux/kernel/git/vkoul/slave-
> > > > dma.git/commit/?h=next&id=8e66e7d682b04f7141f8ae666908c8dcd7fc0b
> > > > fa
> > > > Renames xilinx_vdma_ prefix to xilinx_dma which includes
> > > > renaming of
> > > > the above properties.
> >
> > That patch changes driver from vdma to dma. It does not change
> > property
> > name!
>
> It does. Unfortunately there are no line numbers on that website,
> hence here an excerpt
> from the commit you mention:
> @@ -1220,26 +1220,26 @@ static int xilinx_vdma_chan_probe(struct
> xilinx_vdma_device *xdev,
> if (!has_dre)
> xdev->common.copy_align = fls(width - 1);
>
> - if (of_device_is_compatible(node, "xlnx,axi-vdma-mm2s
> -channel")) {
> + if (of_device_is_compatible(node, "xlnx,axi-dma-mm2s
> -channel")) {
> chan->direction = DMA_MEM_TO_DEV;
> chan->id = 0;
Right, missed that somehow.
Am dropping the patch
--
~Vinod
��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
