Re: [PATCH] mfd: syscon: Allow to using subdevices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hello.

> On Thu, Nov 14, 2013 at 12:52:03PM +0000, Alexander Shiyan wrote:
> > This patch adds support for using subdevices within syscon node.
> > Primary usage of this is describe all devices with same memory
> > region in one container.
> 
> I think if you need to do this, you should not be using syscon. What
> exactly is your use-case?
> 
> I don't like the idea of treating syscon like a bus or container in this
> fashion.

Let me first show the new syscon-based driver. After a while, I'm going
to provide it. It will use the current way of getting syscon, i.e. through
syscon_regmap_lookup_by_phandle().

> > Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> > ---
> >  drivers/mfd/syscon.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> > index 71841f9..6e9244a 100644
> > --- a/drivers/mfd/syscon.c
> > +++ b/drivers/mfd/syscon.c
> > @@ -152,6 +152,9 @@ static int syscon_probe(struct platform_device *pdev)
> >  
> >  	platform_set_drvdata(pdev, syscon);
> >  
> > +	if (of_platform_populate(dev->of_node, NULL, NULL, dev))
> > +		dev_warn(dev, "Fail to create subdevices\n");
> > +
> >  	dev_info(dev, "regmap %pR registered\n", res);
> >  
> >  	return 0;
> > -- 

---
��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux