On Wed, Nov 13, 2013 at 05:33:30PM +0100, Tomasz Figa wrote: > On Wednesday 13 of November 2013 09:44:34 Brian Austin wrote: > > + - reset-gpio : GPIO controller's phandle and the number > > + of the GPIO used to reset the codec. > As Kumar has already mentioned, all device-specific properties should be > prefixed with vendor prefix, "cirrus," in this case. The best practice on this one seems to vary somewhat randomly - sometimes it's a requirement, sometimes it isn't. > > +codec: cs42l52@4a { > coding style: Node name should be generic, i.e. codec@4a. Is this a constructive thing from a style point of view? We're not allowed to actually do anything useful with the value at runtime so people may as well choose what they like.
Attachment:
signature.asc
Description: Digital signature