On 11/11/2013 11:47 PM, Sricharan R wrote: > Hi Rajendra, > > On Tuesday 12 November 2013 11:11 AM, Rajendra Nayak wrote: >> On Tuesday 05 November 2013 06:44 PM, Sricharan R wrote: >>> Enable the crossbar IP support for DRA7xx soc. >>> >>> Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx> >>> Cc: Rajendra Nayak <rnayak@xxxxxx> >>> Cc: Tony Lindgren <tony@xxxxxxxxxxx> >>> Signed-off-by: Sricharan R <r.sricharan@xxxxxx> >>> --- >>> arch/arm/mach-omap2/Kconfig | 1 + >>> arch/arm/mach-omap2/omap4-common.c | 4 ++++ >>> 2 files changed, 5 insertions(+) >>> >>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig >>> index b5fb5f7..2086c65 100644 >>> --- a/arch/arm/mach-omap2/Kconfig >>> +++ b/arch/arm/mach-omap2/Kconfig >>> @@ -141,6 +141,7 @@ config SOC_DRA7XX >>> select ARM_GIC >>> select HAVE_SMP >>> select COMMON_CLK >>> + select IRQ_CROSSBAR >>> >>> comment "OMAP Core Type" >>> depends on ARCH_OMAP2 >>> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c >>> index 5791143..274cbfa 100644 >>> --- a/arch/arm/mach-omap2/omap4-common.c >>> +++ b/arch/arm/mach-omap2/omap4-common.c >>> @@ -22,6 +22,7 @@ >>> #include <linux/of_platform.h> >>> #include <linux/export.h> >>> #include <linux/irqchip/arm-gic.h> >>> +#include <linux/irqchip/irq-crossbar.h> >>> #include <linux/of_address.h> >>> #include <linux/reboot.h> >>> >>> @@ -282,9 +283,12 @@ void __init omap_gic_of_init(void) >>> >>> skip_errata_init: >>> omap_wakeupgen_init(); >>> + if (soc_is_dra7xx()) >>> + crossbar_init(); >> Its good if this is called irqcrossbar_init() to avoid confusion >> with the dma crossbar which also exists in dra7 devices. >> > Ya makes sense. Will change this. Also why not call it without explicit soc check? there is already parse for of_find_matching_node(NULL, crossbar_match); to see if we have a match in the crossbar_init. OR call it from dra7 init without SoC check dependency? Rationale - with more TI SoCs trending towards crossbar, we dont need to keep adding to the soc_is checks, further, we intend to remove soc_is checks in it's entirety.. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
