Hi Sylwester, On 2016년 03월 25일 18:50, Sylwester Nawrocki wrote: > Hi Chanwoo, > > On 03/25/2016 12:39 AM, Chanwoo Choi wrote: >> diff --git a/include/dt-bindings/clock/exynos3250.h >> b/include/dt-bindings/clock/exynos3250.h >>> index ddb874130d86..c796ff02ceeb 100644 >>> --- a/include/dt-bindings/clock/exynos3250.h >>> +++ b/include/dt-bindings/clock/exynos3250.h > ... >>> -#define CLK_NR_CLKS 249 >>> +#define CLK_NR_CLKS 250 > > What do you think about putting all the changes to include/dt-bindings/ > clock/exynos3250.h into a separate patch? Now in patch 3/8 there > is being changed again what was added in patch 2/8. However, my main > point is to have a minimum required in a common topic branch for the clk > and the arm-soc trees, so there is no need for arm-soc to pull all > the drives/clk changes. > It might not be that sensible in case of just those 2 patches in your > series, nevertheless it would be good to keep that in mind for future > submissions. You mean that separate patch1 include only the new clock id about both UART2 and MMC2 and the patch2/patch3 just use the new clock id as following: patch1 dt-bindings: Add the clock id of UART2 and MMC2 for Exynos3250 patch2 clk: samsung: exynos3250: Add UART2 clock patch3 clk: samsung: exynos3250: Add MMC2 clock As far as I understand it is that right? If it is ok, I'll modify it on v4 patchset as you comment. Best Regards, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
