Hello, On Wed, 23 Mar 2016 23:24:21 +0100, Andreas Färber wrote: > Node names should not contain an instance number, the unit address > serves to distinguish nodes of the same name. So rename the XOR nodes > to just xor@address, using xorX as label instead. > > Fixes: ec7e5a569bce ("arm64: dts: marvell: add Device Tree files for Armada 7K/8K") > Cc: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Andreas Färber <afaerber@xxxxxxx> Removing the instance number from the node name is obviously good. However, I don't think it's really needed to add labels. The XOR engines are purely "internal" devices, so they are always enabled at the SoC level. > "marvell,mv-xor-v2" is not yet referenced from any driver in next-20160323. Yes. The driver has been submitted, but has received some comments that I need to address. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html