On Wed, Nov 13, 2013 at 07:40:54AM +0000, Krzysztof Kozlowski wrote:
> From: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
>
> This patch adds max14577 core/irq driver to support MUIC(Micro USB IC)
> device and charger device and support irq domain method to control
> internal interrupt of max14577 device. Also, this patch supports DT
> binding with max14577_i2c_parse_dt().
>
> The MAXIM 14577 chip contains Micro-USB Interface Circuit and Li+ Battery
> Charger. It contains accessory and USB charger detection logic. It supports
> USB 2.0 Hi-Speed, UART and stereo audio signals over Micro-USB connector.
>
> The battery charger is compliant with the USB Battery Charging Specification
> Revision 1.1. It has also SFOUT LDO output for powering USB devices.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
> drivers/mfd/Kconfig | 13 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/max14577-irq.c | 283 +++++++++++++++++++++++++++++++++
> drivers/mfd/max14577.c | 268 +++++++++++++++++++++++++++++++
> include/linux/mfd/max14577-private.h | 291 ++++++++++++++++++++++++++++++++++
> include/linux/mfd/max14577.h | 76 +++++++++
> 6 files changed, 932 insertions(+)
> create mode 100644 drivers/mfd/max14577-irq.c
> create mode 100644 drivers/mfd/max14577.c
> create mode 100644 include/linux/mfd/max14577-private.h
> create mode 100644 include/linux/mfd/max14577.h
I see some of_* calls in the code, but no documentation of the binding.
As this has more than just a compatible, interrupts, and reg, it needs
its own binding document.
[...]
> +static struct mfd_cell max14577_devs[] = {
> + { .name = "max14577-muic",
> + .of_compatible = "maxim,max14577-muic", },
The compatible string looks fine to me, but should be documented.
[...]
> +#ifdef CONFIG_OF
> +static struct max14577_platform_data *max14577_i2c_parse_dt(struct device *dev)
> +{
> + struct max14577_platform_data *pdata;
> + struct device_node *np = dev->of_node;
> +
> + pdata = devm_kzalloc(dev, sizeof(struct max14577_platform_data),
> + GFP_KERNEL);
> + if (!pdata)
> + return ERR_PTR(-ENOMEM);
> +
> + pdata->irq_gpio = of_get_named_gpio(np, "irq_gpio", 0);
In general, '-' is preferred to '_' in property names. This should be
irq-gpio.
What exactly is this used for? I know that others have strong opinions
about how gpio/irq interaction should be handled.
> + if (!gpio_is_valid(pdata->irq_gpio)) {
> + dev_err(dev, "Invalid irq_gpio in DT\n");
> + return ERR_PTR(-EINVAL);
> + }
> +
> + if (of_property_read_bool(np, "wakeup"))
> + pdata->wakeup = true;
What does this mean? It seems like a remarkably generic name for
something that I'd guess is _very_ specific to this particular binding.
It might be worth prefixing it, and is certainly worth having a more
precise name.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
