Re: [PATCH] Input: rotary_encoder - support binary encoding of states

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 03/23/2016 01:46 PM, Rob Herring wrote:
> On Wed, Mar 23, 2016 at 1:49 AM, Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:

>>> Fine, but "rotary-encoder" is not a vendor I've ever heard of. Just
>>> "encoding" is sufficient.
>>
>> I picked that to be consistent with rotary-encoder,steps and other
>> already existing properties documented in
>> Documentation/devicetree/bindings/input/rotary-encoder.txt.
> 
> Uggg.

IIRC, the discussion back then concluded that there should be no
properties without prefixes except for properties that are really
generic, which wasn't an applicable argument for those of this driver.
Then again, this goes back many years, and the rules might have changed.

>> Should the prefix be dropped for these, too (with compat code)?
> 
> On one hand, there's only one user of one property in the kernel, but
> I'd guess there are others in the wild. Probably not worth carrying
> both, so I guess just leave this for consistency.

Wasn't there a general agreement to *not* provide guarantees on the
stability of TD bindings, in order to be able to refactor and unify
them? Sorry, I haven't followed the discussion around all that for a
while, so I'm just asking out of curiosity.

As far as I'm concerned, I could live with any kind of such change and
notify the users I know of personally so they can follow up. But I don't
know about others of course.


Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux