On Wed, 23 Mar 2016 11:18:59 +0100 Rafał Miłecki <zajec5@xxxxxxxxx> wrote: > Some time ago I started working on a new "nand-ecc-algo" property to allow > specifying ECC algorithm for hardware ECC mode as well. > Boris pointed out it's becoming a bit messy that way as we already have value > NAND_ECC_SOFT_BCH. > I suggested deprecating "soft_bch" value from nand-ecc-mode property and got > Boris agreed and no objections from others. So there is how I want to implement > this. > If you agree on this way & apply my patches, I'll start modifying NAND drivers > (similarly to the nandsim) and then will try to drop NAND_ECC_SOFT_BCH except > for handling backward compatibility. > Then finally we should be able to add "nand-ecc-algo" property support properly. > > V2: Add of_get_nand_ecc_algo helper (in 2/4) instead of this slightly hacky code > in nand_dt_init that would be replaced anyway. This version looks good to me. If nobody disagree, I'll apply those patches on my future nand/next branch. Thanks, Boris > > Rafał Miłecki (4): > mtd: nand: add new enum for storing ECC algorithm > of: mtd: prepare helper reading NAND ECC algo from DT > mtd: nand: set ECC algorithm in nand_dt_init > mtd: nand: nandsim: set ECC algorithm explicitly > > drivers/mtd/nand/nand_base.c | 6 +++++- > drivers/mtd/nand/nandsim.c | 2 ++ > drivers/of/of_mtd.c | 36 ++++++++++++++++++++++++++++++++++++ > include/linux/mtd/nand.h | 7 +++++++ > include/linux/of_mtd.h | 6 ++++++ > 5 files changed, 56 insertions(+), 1 deletion(-) > -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
