On Wednesday 13 of November 2013 09:01:36 Sachin Kamat wrote:
> Hi Kukjin,
>
> On 12 November 2013 16:31, Kukjin Kim <kgene@xxxxxxxxxx> wrote:
> > Sachin Kamat wrote:
> >>
> >> Since there are no board specific properties for the RTC node,
> >> keep it enabled in the dtsi file.
> >>
> >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> >> ---
> >> arch/arm/boot/dts/exynos4.dtsi | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi
> >> b/arch/arm/boot/dts/exynos4.dtsi
> >> index a73eeb5..e262946 100644
> >> --- a/arch/arm/boot/dts/exynos4.dtsi
> >> +++ b/arch/arm/boot/dts/exynos4.dtsi
> >> @@ -205,7 +205,6 @@
> >> interrupts = <0 44 0>, <0 45 0>;
> >> clocks = <&clock 346>;
> >> clock-names = "rtc";
> >> - status = "disabled";
> >> };
> >>
> >> keypad@100A0000 {
> >> --
> >> 1.7.9.5
> >
> > Well, I don't think every exynos4 boards want to make the default
> > enabled...so I don't want to take this. If any opinions, please let me know.
> >
>
> As was discussed earlier too, status field of DT node is not supposed
> to be used for
> keeping an IP enabled or disabled. That should be done via the kernel
> config. The DT status
> is mostly to indicate the hardware status of the IP on the SoC/board.
> If the node fully defines the hardware,
> then it should be kept enabled by default unless such enabling causes
> some issues with other IPs due to
> pin sharing conflicts, etc. In the above case the node completely
> defines the hardware and hence there is no
> reason to keep it disabled.
That's correct. (Unless I'm missing some board specific dependency of RTC.
If so, please correct me.)
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
