On 12 November 2013 15:47, Kukjin Kim <kgene@xxxxxxxxxx> wrote: > Sachin Kamat wrote: >> > + dt ml. > >> As per the timing information for supported panel, the value should >> be between 47.2 MHz to 47.9 MHz for 60Hz refresh rate. >> >> Total horizontal pixels = 1024 (x-res) + 80 (margin) + 48 (hsync) = 1152 >> Total vertical pixels = 600 (y-res) + 80 (margin) + 3 (vsync) = 653 > > Should be 683? > >> >> Target pixel clock rate for refresh rate @60 Hz >> = 1152 * 653 * 60 = 47208960 Hz ~ 47.5 MHz >> > Same here. > Yes, typo in both the cases, however the calculation is right. The same typo in patch 1/2 also. You may please fix them while applying. >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> >> --- >> arch/arm/boot/dts/exynos4412-origen.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts >> b/arch/arm/boot/dts/exynos4412-origen.dts >> index 8768b03..923bcd7 100644 >> --- a/arch/arm/boot/dts/exynos4412-origen.dts >> +++ b/arch/arm/boot/dts/exynos4412-origen.dts >> @@ -152,7 +152,7 @@ >> display-timings { >> native-mode = <&timing0>; >> timing0: timing { >> - clock-frequency = <50000>; >> + clock-frequency = <47500000>; >> hactive = <1024>; >> vactive = <600>; >> hfront-porch = <64>; >> -- >> 1.7.9.5 > > Please make sure it works fine on both origen boards with your two fixes. > > If so, let me pick them up into Samsung tree after squash into one patch. > > Thanks, > Kukjin > Thanks. -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html