Hello Linus, On Wed, Mar 9, 2016 at 10:55 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Sat, Mar 5, 2016 at 10:42 PM, Vishnu Patekar > <vishnupatekar0510@xxxxxxxxx> wrote: > >> The A83T has R_PIO pin controller, it's same as A23, execpt A83T >> interrupt bit is 6th and A83T has one extra pin PL12. >> >> Signed-off-by: Vishnu Patekar <vishnupatekar0510@xxxxxxxxx> >> Acked-by: Chen-Yu Tsai <wens@xxxxxxxx> >> Acked-by: Rob Herring <robh@xxxxxxxxxx> > > As partly noted by others: > >> +config PINCTRL_SUN8I_A83T_R >> + def_bool MACH_SUN8I > > bool > >> + depends on RESET_CONTROLLER > > Should it rather select RESET_CONTROLLER? I used depends on and def_bool as it is used for other sunxi pinctrl drivers. Using bool and select will not harm anything. Should I change it to bool and select ? or keep it to be uniform with earlier options? > >> +static const struct of_device_id sun8i_a83t_r_pinctrl_match[] = { >> + { .compatible = "allwinner,sun8i-a83t-r-pinctrl", }, >> + {} >> +}; >> +MODULE_DEVICE_TABLE(of, sun8i_a83t_r_pinctrl_match); > > Module talk in bool driver. I'll remove it. > >> +static struct platform_driver sun8i_a83t_r_pinctrl_driver = { >> + .probe = sun8i_a83t_r_pinctrl_probe, >> + .driver = { >> + .name = "sun8i-a83t-r-pinctrl", >> + .of_match_table = sun8i_a83t_r_pinctrl_match, >> + }, >> +}; >> +module_platform_driver(sun8i_a83t_r_pinctrl_driver); > > Should be builtin? Yes, It should be. I missed Maxime's earlier commets. > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html