On Tue, 12 Nov 2013, Russell King - ARM Linux wrote: > On Mon, Nov 11, 2013 at 04:59:14PM +0000, Stefano Stabellini wrote: > > On Wed, 6 Nov 2013, Stefano Stabellini wrote: > > > On Sat, 2 Nov 2013, Grant Likely wrote: > > > > On Wed, 30 Oct 2013 00:05:22 -0500, Rob Herring <robherring2@xxxxxxxxx> wrote: > > > > > From: Rob Herring <rob.herring@xxxxxxxxxxx> > > > > > > > > > > Platform devices created by DT code don't initialize dma_mask pointer to > > > > > anything. Set it to coherent_dma_mask by default if the architecture > > > > > code has not set it. > > > > > > > > > > Signed-off-by: Rob Herring <rob.herring@xxxxxxxxxxx> > > > > > > > > I believe this is okay. I haven't done any testing to back up that > > > > opinion though. > > > > > > Tested-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> > > > > BTW I hope you are planning on sending this upstream soon, because > > without it I can very easily corrupt my root fs by simply booting the system. > > What's the mechanism for that corruption? Having the DMA mask not set > should not cause DMA corruption - that hints at something else being > wrong, and that needs to be investigated. Russell, you are right. I went through the swiotlb-xen code and I realized that I missed a map_page call on one of the (usually unused) fallback paths. Thanks!! -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
