On Fri, Dec 18, 2015 at 4:32 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Tuesday 15 December 2015 00:58:26 Rafael J. Wysocki wrote: >> On Thursday, November 26, 2015 05:21:11 PM Jia Hongtao wrote: >> > Register the qoriq cpufreq driver as a cooling device, based on the >> > thermal device tree framework. When temperature crosses the passive trip >> > point cpufreq is used to throttle CPUs. >> > >> > Signed-off-by: Jia Hongtao <hongtao.jia@xxxxxxxxxxxxx> >> > Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> >> >> Applied, thanks! >> > > I got a randconfig build error today: > > drivers/built-in.o: In function `qoriq_cpufreq_ready': > debugfs.c:(.text+0x1f4688): undefined reference to `of_cpufreq_cooling_register' > > CONFIG_OF=y > CONFIG_QORIQ_CPUFREQ=y > CONFIG_THERMAL=m > CONFIG_THERMAL_OF=y > > I think you need a 'depends on THERMAL' to prevent the driver from > being built-in when THERMAL=m. Maybe this is not the best approach. The cpufreq feature itself should be working independently without thermal framework. I think we should make the qoriq_cpufreq_ready() defined as null function if THERMAL is not defined. Regards, Leo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
