On 11/11/2013 09:07 PM, Arnaud Ebalard wrote:
Hi Sebastian, Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> writes:@@ -154,6 +161,30 @@ gpios = <&gpio2 0 1>; /* GPIO 64 Active Low */ linux,default-trigger = "keep"; }; + + sata1_led { + label = "rn104:blue:sata1"; + gpios = <&pca9554 0 1>; /* Active Low */Same comment as for ReadyNAS 2120 patch: #include <dt-bindings/gpio/gpio.h> and use GPIO_ACTIVE_HIGH/LOW.Unlike RN2120 .dts for which I was able to change all the high/low values for macros in a single move, if I do the changes here for this specific patch, the .dts file for the RN104 will contain both values and macros. What about the following options?: - send a preliminary patch to change all the values for macros in RN104 .dts file once -rc1 is here and then resubmit the PCA9554 patch with macros? - have the patch applied as is and then convert the whole RN104 .dts w/ another patch.
I'd say, respin this with gpio.h and go for a round of cleanup later.
Anyway, once RN2120 is accepted, I intend to spend some time doing some housekeeping on other readynas .dts file based on the comments you made recently (macros, reg, addressing, phy info, etc), and also some minor points (whitespaces).
Great! Sebastian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
