Hi Joachim, 2016-02-23 23:37 GMT+01:00 Joachim Eastwood <manabian@xxxxxxxxx>: > Hi Alexandre, > > You should copy 'devicetree@xxxxxxxxxxxxxxx' on bindings doc. Adding cc here. > > On 23 February 2016 at 16:10, Alexandre TORGUE > <alexandre.torgue@xxxxxxxxx> wrote: >> Signed-off-by: Alexandre TORGUE <alexandre.torgue@xxxxxxxxx> >> >> diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >> new file mode 100644 >> index 0000000..18734b3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >> @@ -0,0 +1,41 @@ >> +STMicroelectronics STM32 / MCU DWMAC glue layer controller >> + >> +This file documents platform glue layer for stmmac. >> +Please see stmmac.txt for the other unchanged properties. >> + >> +The device node has following properties. >> + >> +Required properties: >> +- compatible: Should be "st,stm32-dwmac" to select glue, and >> + "snps,dwmac-3.50a" to select IP vesrion. >> +- clocks: Should contain the GMAC main clock, and tx clock >> +- compatible: Should be "st,stm32-dwmac" to select glue and >> + "snps,dwmac-3.50a" to select IP version. >> +- clocks: Should contain the MAC main clock >> +- clock-names: Should contain the clock names "stmmaceth". >> +- st,syscon : Should be phandle/offset pair. The phandle to the syscon node which >> + encompases the glue register, and the offset of the control register. >> + >> +Optional properties: >> +- clocks: Could contain: >> + - the tx clock, >> + - the rx clock >> +- clock-names: Could contain the clock names "tx-clk", "rx-clk" >> + >> +Example: >> + >> + ethernet0: dwmac@40028000 { >> + device_type = "network"; > > What is this 'device_type = "network"' for? > It seems to used in a lot of powerpc DTs, but only a couple of arm DTs. Actually it seems that this entry is deprecated for ARM (http://lists.openwall.net/linux-kernel/2013/12/11/372) Concerning stmmac driver I don't see an issue to remove it (tested). So If Rob and Peppe could confirm, I will remove it in my V3. Br Alexandre > > Maybe Rob could enlighten us? > >> + compatible = "st,stm32-dwmac", "snps,dwmac-3.50a"; >> + status = "disabled"; >> + reg = <0x40028000 0x8000>; >> + reg-names = "stmmaceth"; >> + interrupts = <0 61 0>, <0 62 0>; >> + interrupt-names = "macirq", "eth_wake_irq"; >> + clock-names = "stmmaceth", "tx-clk", "rx-clk"; >> + clocks = <&rcc 0 25>, <&rcc 0 26>, <&rcc 0 27>; >> + st,syscon = <&syscfg 0x4>; >> + snps,pbl = <32>; > > Regarding snps,pbl; using 32 here might not give you what you would except. > See comment in dwmac1000_dma_init(). > > The driver is hard coded to use PBL4X/PBL8X mode. Just a heads up. > > > regards, > Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html