On Wen, Feb 24, 2016 at 04:22AM, Rob Herring wrote: > -----Original Message----- > From: Rob Herring [mailto:robh@xxxxxxxxxx] > Sent: Wednesday, February 24, 2016 4:22 AM > To: Qiang Zhao <qiang.zhao@xxxxxxx> > Cc: oss@xxxxxxxxxxxx; Yang-Leo Li <leoyang.li@xxxxxxx>; linux- > kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linuxppc- > dev@xxxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 2/7] QE: Add ucc hdlc document to bindings > > On Thu, Feb 18, 2016 at 09:06:07AM +0800, Zhao Qiang wrote: > > Add ucc hdlc document to > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt > > Not a very useful description. Could you give a example for me? > > > Signed-off-by: Zhao Qiang <qiang.zhao@xxxxxxx> > > --- > > Changes for v2 > > - use ucc-hdlc instead of ucc_hdlc > > - add more information to properties. > > > > .../bindings/powerpc/fsl/cpm_qe/network.txt | 93 > ++++++++++++++++++++++ > > 1 file changed, 93 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt > > index 29b28b8..936158c 100644 > > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt > > +++ > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt > > @@ -41,3 +41,96 @@ Example: > > fsl,mdio-pin = <12>; > > fsl,mdc-pin = <13>; > > }; > > + > > +* HDLC > > + > > +Currently defined compatibles: > > +- fsl,ucc-hdlc > > + > > +Properties for fsl,ucc-hdlc: > > +- rx-clock-name > > +- tx-clock-name > > + Usage: required > > + Value type: <string> > > + Definition : should be "brg1"-"brg16" for internal clock source, > > + should be "clk1"-"clk28" for external clock source. > > + > > +- fsl,rx-sync-clock > > + Usage: required > > + Value type: <string> > > + Definition : should be "none" when using internal clock source, > > + should be "rsync_pin" when using external clock source. > > Why not a boolean property here? fsl,rx-sync-clock should have other values. But now we just use rsync_pin and none. > > + > > +- fsl,tx-timeslot > > +- fsl,rx-timeslot > > Perhaps append "-mask" Agree, I will modify in next version. > > > + Usage: required > > + Value type: <u32> > > + Definition : time slot for TDM operation. Indicates which time slots > > + used for transmitting and receiving. > > + > > +- fsl,tdm-framer-type > > + Usage: required > > + Value type: <string> > > + Definition : "e1" or "t1" > > Boolean? We just support e1 and t1, in fact, there are more TDM framer types. > > > + > > +- fsl,tdm-mode > > + Usage: required > > + Value type: <string> > > + Definition : "normal" or "internal-loopback" > > Boolean? It can be Boolean. BR -Zhao -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
