Hello, FWIW, you're replying to the v1 of this patch, while v2 and v3 have already been posted, and v3 has already been merged by the irqchip maintainers: http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=c27f29bbbf02168c9b1e8ba0fe7a8cb917e5a50f On Sun, 21 Feb 2016 20:53:53 -0600, Rob Herring wrote: > > +- compatible : The value here should contain "marvell,odmi-controller". > > SoC specific compatible too please. I can add that in a follow-up patch. > > +- marvell,spi-base : List of GIC base SPI interrupts, one for each > > + ODMI frame. > > Why not "interrupts" property? This has already been discussed with Arnd in a more recent iteration of the patch: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/409411.html http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/409415.html http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/409430.html Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
