On Mon, Nov 11, 2013 at 10:16:22AM +0000, Mark Rutland wrote: > On Thu, Nov 07, 2013 at 08:22:17PM +0000, Brian Austin wrote: > > + - chgfreq : Charge Pump Frequency values 0x00-0x0F > In general, longer but more easily understood names are preferred (e.g. > "clock-frequency"). This could be "charge-pump-frequency". I rather suspect that this is the name of the register that gets the raw value specified written to it - using the register name seems reasonable for that. > > + - micbias_lvl: Set the output voltage level on the MICBIAS Pin > > + 0x00 = 0.5 x VA > > + 0x01 = 0.6 x VA > > + 0x02 = 0.7 x VA > > + 0x03 = 0.8 x VA > > + 0x04 = 0.83 x VA > > + 0x05 = 0.91 x VA > Is this not something we'd want to change at runtime instead? Why does > this need to be in the dt? This is something that would come from the electrical design of the system rather than something that users would tune at runtime.
Attachment:
signature.asc
Description: Digital signature