On Fri, Nov 8, 2013 at 2:56 PM, Markus Pargmann <mpa@xxxxxxxxxxxxxx> wrote: > On Fri, Nov 08, 2013 at 10:45:01AM +0100, Linus Walleij wrote: >> If the I/O region is tightly coupled across two subsystems like >> that we usually merge the driver into one combined >> pinctrl+gpio driver and put it into drivers/pinctrl/*. > > The gpio module does not necessarily include a pinctrl module. Most of > the imx SoCs have the same gpio function registers but without pinctrl. > They all use the same gpio driver. Yeah but I'm only saying you could make a combined driver, I didn't say you had to use both halves of it all the time. pinctrl/pinctrl-imx1.c can very well handle both and only supply GPIO functionality for some compatible-strings, that's OK. > There are 6 gpio modules in the memory region from 0x10015000 to > 0x100155ff. pinctrl is in the same memory region. OK I get it (I think). > I could change the bindings back to that from v1 [1]. One pinmux > controller over the full memory range (0x10015000 0x600) and the gpio > modules as subnodes using 0x100 each. This would preserve the currently > used references to the gpio nodes. Hm I don't really have opinions on this, better let the DT-folks say what they prefer. But that looks good to me. Can you do this with an incremental patch? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html