On Fri, Feb 12, 2016 at 11:26 AM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > Hello. > > > On 02/12/2016 07:21 PM, Rob Herring wrote: > >>> This adds DT support for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. >>> >>> Signed-off-by: Petr Kulhavy <petr@xxxxxxxxx> >>> --- >>> .../devicetree/bindings/usb/da8xx-usb.txt | 47 >>> ++++++++++++++++++++++ >>> 1 file changed, 47 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/usb/da8xx-usb.txt >>> >>> diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt >>> b/Documentation/devicetree/bindings/usb/da8xx-usb.txt >>> new file mode 100644 >>> index 0000000..62dcc51 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt >>> @@ -0,0 +1,47 @@ >>> +TI DA8xx MUSB >>> +~~~~~~~~~~~~~ >>> +For DA830 and DA850 platforms. >>> + >>> +Required properties: >>> +~~~~~~~~~~~~~~~~~~~~ >>> + - compatible : Should be set to "ti,da830-musb". >>> + >>> + - reg: Offset and length of the USB controller register set. >>> + >>> + - interrupts: The USB interrupt number. >>> + >>> + - interrupt-names: Should be set to "mc". >>> + >>> + - dr_mode: The USB operation mode. Should be one of "host", >>> "peripheral" or "otg". >>> + >>> + - mentor,power : Specifies the maximum current in milliamperes the >>> controller can >>> + supply in host mode. >> >> >> Still a no for me. > > > Note that it's been used twice already, for musb_dsps.c and omap2430.c > glues (in the latter case the prop was called just "power"). The > corresponding field is a part of the 'struct musb_hdrc_platform_data'. Copied from platform_data is exactly what is wrong with this binding and you already said those were bad examples. >> Looks like this just sets hcd->power_budget. This >> property may not be a regulator, but ultimately the value depends on >> some regulator supplying Vbus. > > > Yes. > >> Also, given this has nothing to do with MUSB h/w, > > > This regulator is controlled by the DRVVBUS signal from MUSB h/w! How does a single signal control amount of current? What I should say is the max current has nothing to do with the MUSB controller. It is a property of some regulator. >> however this is described should be generic. > > > You mean just "power", w/o the vendor prefix? No. I mean generic in the sense of common for all USB host bindings, not generic as in a meaningless, unclear name. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
