Hi Guenter, Guenter Roeck <linux@xxxxxxxxxxxx> writes: > On Sat, Nov 09, 2013 at 06:39:14PM +0100, Arnaud Ebalard wrote: >> >> This was tested on a NETGEAR ReadyNAS 2120 device (Marvell Armada XP >> based board, via DT). >> >> Signed-off-by: Arnaud Ebalard <arno@xxxxxxxxxxxx> > > Looks good. I'll apply it to my -next branch. Since I already sent my > pull request to Linus, this will only go in after -rc1, which I hope > should be ok (unless Jean wants to pick it up for his pull request). Perfect, thanks. >> --- >> Hi Guenter, >> >> As a side note, I removed the hunk that was present in previous patch to >> add gmt to the list of DT vendor prefixes because I noticed someone had >> taken care: https://lkml.org/lkml/2013/9/12/365 >> >> For the records, here is what I get on my NAS with the attached patch: >> >> root@thin:/sys# sensors >> g762-i2c-0-3e >> Adapter: mv64xxx_i2c adapter >> fan1: 5461 RPM (div = 1) >> >> g762-i2c-0-48 >> Adapter: mv64xxx_i2c adapter >> fan1: 5461 RPM (div = 1) >> >> g762-i2c-0-49 >> Adapter: mv64xxx_i2c adapter >> fan1: 5461 RPM (div = 1) >> > Those rpms are pretty high. Are the fans all really running that fast ? Unlike the fans on NETGEAR ReadyNAS 102 and 104 which are Protechnic MGT9212YB-025 92mmx92mm running at 3200 RPM max, the three fans in the RN2120 are Protechnic MGT4012XB-O20, i.e. 40mmx40mm running at 8000 RPM max. At least, this is the max RPM value I found on their website (Search Products on left side of http://www.protechnic-us.com/en/) for both devices. When pushing one a bit, here is the max rotation speed I get: root@thin:/sys/bus/i2c/drivers/g762/0-003e# echo 9000 > fan1_target ; \ sleep 5 ; cat fan1_input 8057 which AFAICT validates current settings for G762 and fan combination. Did I miss something? Cheers, a+ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html