> > > > Please use the GPIO DT binding. Reading a number from DT is not a > > > > proper way to get a GPIO number, as you may have more than one > > > > GPIO controller in a system and it is not obvious to which > > > > controller this number belongs, or if you need to specify things > like polarity. > > > > > > My read of this is it is not the host SOC gpio, but the WiFi > > > device's GPIO number. The host GPIO is defined in patch 3. We could > > > still use the GPIO binding to describe it doing something like > > > "marvell,<wifi gpio pin > > > name>-gpios". Then the assignment is based on the property name. > > I see. > > > Yes. This is not host SOC gpio. It's wifi chip's gpio number. > > We will use GPIO binding for this in updated version. > > No, if it doesn't refer to a number that is interpreted by the host but > is used internally in the device, then leave it as it is, as Rob > suggested. > It won't be interpreted by host. I will keep it as is and just rename from "mwifiex,chip-gpio" to "marvell,wakeup-gpios" Regards, Amitkumar Karwar. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
